Skip to content

Remove MLflow integration#5246

Merged
nabenabe0928 merged 5 commits intooptuna:masterfrom
y0z:feature/migrate-mlflow
Feb 16, 2024
Merged

Remove MLflow integration#5246
nabenabe0928 merged 5 commits intooptuna:masterfrom
y0z:feature/migrate-mlflow

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 13, 2024

Motivation

Description of the changes

@y0z y0z marked this pull request as ready for review February 13, 2024 07:01
@y0z
Copy link
Copy Markdown
Member Author

y0z commented Feb 13, 2024

In CI, Coverage / coverage (pull_request) failed but the cause looks unrelated to this PR.

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (32f5ce9) 89.30% compared to head (b5d4dfb) 89.19%.

Files Patch % Lines
optuna/integration/mlflow.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5246      +/-   ##
==========================================
- Coverage   89.30%   89.19%   -0.11%     
==========================================
  Files         206      206              
  Lines       13034    12944      -90     
==========================================
- Hits        11640    11546      -94     
- Misses       1394     1398       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HideakiImamura HideakiImamura self-assigned this Feb 15, 2024
Co-authored-by: Hideaki Imamura <38826298+HideakiImamura@users.noreply.github.com>
@y0z
Copy link
Copy Markdown
Member Author

y0z commented Feb 15, 2024

I applied all the comments. PTAL.

Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, could you resolve the conflict?

@y0z
Copy link
Copy Markdown
Member Author

y0z commented Feb 16, 2024

I resolved the conflict 🙌

@nabenabe0928 nabenabe0928 merged commit 323519d into optuna:master Feb 16, 2024
@nabenabe0928 nabenabe0928 added the compatibility Change that breaks compatibility. label Feb 16, 2024
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 16, 2024
@y0z y0z deleted the feature/migrate-mlflow branch February 16, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants