Skip to content

Remove the wandb integration#5237

Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom
y0z:feature/wandb
Feb 9, 2024
Merged

Remove the wandb integration#5237
nabenabe0928 merged 2 commits intooptuna:masterfrom
y0z:feature/wandb

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 8, 2024

Motivation

Description of the changes

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4d39631) 90.04% compared to head (37c4029) 90.00%.
Report is 5 commits behind head on master.

❗ Current head 37c4029 differs from pull request most recent head e645814. Consider uploading reports for the commit e645814 to get more accurate results

Files Patch % Lines
optuna/integration/wandb.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5237      +/-   ##
==========================================
- Coverage   90.04%   90.00%   -0.05%     
==========================================
  Files         213      213              
  Lines       14365    14302      -63     
==========================================
- Hits        12935    12872      -63     
  Misses       1430     1430              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53
Copy link
Copy Markdown
Member

@nabenabe0928 Could you review this PR?

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 9, 2024
@nabenabe0928 nabenabe0928 removed their assignment Feb 9, 2024
@contramundum53 contramundum53 added the compatibility Change that breaks compatibility. label Feb 9, 2024
@nabenabe0928 nabenabe0928 merged commit 11dca39 into optuna:master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants