Skip to content

Remove the cma integration#5236

Merged
nabenabe0928 merged 4 commits intooptuna:masterfrom
y0z:feature/cma
Feb 9, 2024
Merged

Remove the cma integration#5236
nabenabe0928 merged 4 commits intooptuna:masterfrom
y0z:feature/cma

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 8, 2024

Motivation

Description of the changes

@github-actions github-actions bot added optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions. labels Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (83d6b1a) 90.04% compared to head (82ca3d1) 89.80%.

Files Patch % Lines
optuna/integration/cma.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5236      +/-   ##
==========================================
- Coverage   90.04%   89.80%   -0.24%     
==========================================
  Files         213      213              
  Lines       14365    14127     -238     
==========================================
- Hits        12935    12687     -248     
- Misses       1430     1440      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@contramundum53
Copy link
Copy Markdown
Member

Could you review this PR? @nabenabe0928

Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53 contramundum53 removed their assignment Feb 9, 2024
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 removed their assignment Feb 9, 2024
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 9, 2024
@nabenabe0928 nabenabe0928 merged commit b5d41d8 into optuna:master Feb 9, 2024
@contramundum53 contramundum53 added the compatibility Change that breaks compatibility. label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. optuna.samplers Related to the `optuna.samplers` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants