Skip to content

Remove SkoptSampler#5234

Merged
nabenabe0928 merged 2 commits intooptuna:masterfrom
Alnusjaponica:move-scikit-optimize
Feb 8, 2024
Merged

Remove SkoptSampler#5234
nabenabe0928 merged 2 commits intooptuna:masterfrom
Alnusjaponica:move-scikit-optimize

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica commented Feb 8, 2024

Motivation

Progress #4484

Description of the changes

This PR removed all SkoptSampler related files. Note that it is not tested here since deprecated.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a8aa5c1) 89.01% compared to head (e4e0e1d) 90.04%.
Report is 13 commits behind head on master.

Files Patch % Lines
optuna/integration/skopt.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5234      +/-   ##
==========================================
+ Coverage   89.01%   90.04%   +1.02%     
==========================================
  Files         213      213              
  Lines       14523    14365     -158     
==========================================
+ Hits        12928    12935       +7     
+ Misses       1595     1430     -165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nabenabe0928
nabenabe0928 reviewed Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked git grep skopt, but scikit-optimize is not used in documentation, so scikit-optimize should be able to be removed from the document dependencies as well.

nabenabe0928
nabenabe0928 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928
Copy link
Copy Markdown
Contributor

nabenabe0928 commented Feb 8, 2024

@y0z Could you review this PR?

y0z
y0z approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabenabe0928 nabenabe0928 merged commit 83d6b1a into optuna:master Feb 8, 2024
@Alnusjaponica Alnusjaponica deleted the move-scikit-optimize branch February 8, 2024 08:01
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 8, 2024
@contramundum53 contramundum53 added code-fix Change that does not change the behavior, such as code refactoring. compatibility Change that breaks compatibility. and removed code-fix Change that does not change the behavior, such as code refactoring. labels Feb 9, 2024
@nabenabe0928 nabenabe0928 mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y0z y0z y0z approved these changes

+1 more reviewer

@nabenabe0928 nabenabe0928 nabenabe0928 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@y0z y0z

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Alnusjaponica @nabenabe0928 @y0z @contramundum53