Skip to content

Migrate the sklearn integration.#5225

Merged
nabenabe0928 merged 1 commit intooptuna:masterfrom
y0z:feature/optunasearchcv-isolation
Feb 7, 2024
Merged

Migrate the sklearn integration.#5225
nabenabe0928 merged 1 commit intooptuna:masterfrom
y0z:feature/optunasearchcv-isolation

Conversation

@y0z
Copy link
Copy Markdown
Member

@y0z y0z commented Feb 5, 2024

Motivation

Description of the changes

@y0z y0z marked this pull request as draft February 5, 2024 04:25
@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Feb 5, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (53d8554) 89.37% compared to head (f4e4611) 89.16%.
Report is 9 commits behind head on master.

Files Patch % Lines
optuna/integration/sklearn.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5225      +/-   ##
==========================================
- Coverage   89.37%   89.16%   -0.21%     
==========================================
  Files         206      206              
  Lines       15097    14745     -352     
==========================================
- Hits        13493    13148     -345     
+ Misses       1604     1597       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y0z y0z marked this pull request as ready for review February 5, 2024 06:52
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@contramundum53
Copy link
Copy Markdown
Member

@nabenabe0928 Could you review this PR?

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabenabe0928 nabenabe0928 merged commit d588eca into optuna:master Feb 7, 2024
@y0z y0z deleted the feature/optunasearchcv-isolation branch February 7, 2024 08:08
@not522 not522 added this to the v3.6.0 milestone Feb 8, 2024
@not522 not522 added the compatibility Change that breaks compatibility. label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants