Skip to content

Remove pytorch integration#5213

Merged
contramundum53 merged 9 commits intooptuna:masterfrom
nabenabe0928:code-fix/isolate-pytorch
Feb 14, 2024
Merged

Remove pytorch integration#5213
contramundum53 merged 9 commits intooptuna:masterfrom
nabenabe0928:code-fix/isolate-pytorch

Conversation

@nabenabe0928
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 commented Jan 29, 2024 •
edited
Loading

Motivation

Remove dependecies related to PyTorch.

Description of the changes

Remove PyTorch Lightning, PyTorch Ignite, and PyTorch.
Please merge this PR first.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Jan 29, 2024
y0z
y0z requested changes Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@y0z y0z left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some suggestions for code fixes.

@y0z
Copy link
Copy Markdown
Member

y0z commented Feb 5, 2024 •
edited
Loading

This PR progresses #4484.
Related PR: optuna/optuna-integration#62.

@y0z y0z mentioned this pull request Feb 5, 2024
Merged
@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented Feb 6, 2024

@nabenabe0928 Could you move these CI to optuna_integration?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7f70eb2) 89.88% compared to head (5daeb95) 89.83%.

Files Patch % Lines
optuna/integration/pytorch_distributed.py 0.00% 2 Missing ⚠️
optuna/integration/pytorch_ignite.py 0.00% 2 Missing ⚠️
optuna/integration/pytorch_lightning.py 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5213      +/-   ##
==========================================
- Coverage   89.88%   89.83%   -0.06%     
==========================================
  Files         213      213              
  Lines       14004    13707     -297     
==========================================
- Hits        12587    12313     -274     
+ Misses       1417     1394      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabenabe0928
Copy link
Copy Markdown
Contributor Author

nabenabe0928 commented Feb 9, 2024

@contramundum53 Could you review this PR?

@nabenabe0928 nabenabe0928 mentioned this pull request Feb 13, 2024
Closed
contramundum53
contramundum53 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

y0z
y0z approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@contramundum53 contramundum53 merged commit e905252 into optuna:master Feb 14, 2024
@nabenabe0928 nabenabe0928 added the compatibility Change that breaks compatibility. label Feb 14, 2024
@nabenabe0928 nabenabe0928 added this to the v3.6.0 milestone Feb 14, 2024
@nabenabe0928 nabenabe0928 deleted the code-fix/isolate-pytorch branch February 19, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@contramundum53 contramundum53 contramundum53 approved these changes

@y0z y0z y0z approved these changes

Assignees

No one assigned

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nabenabe0928 @y0z @contramundum53