Skip to content

Delete tensorboard integration for migration to optuna-integration#5161

Merged
HideakiImamura merged 4 commits intooptuna:masterfrom
dheemantha-bhat:master
Jan 10, 2024
Merged

Delete tensorboard integration for migration to optuna-integration#5161
HideakiImamura merged 4 commits intooptuna:masterfrom
dheemantha-bhat:master

Conversation

@dheemantha-bhat
Copy link
Copy Markdown
Contributor

@dheemantha-bhat dheemantha-bhat commented Dec 22, 2023

Motivation

Progress #4484

Description of the changes
Move integration/tensorboard.py and its test from optuna/optuna.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Dec 22, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d430a23) 89.40% compared to head (4caf669) 89.38%.
Report is 19 commits behind head on master.

Files Patch % Lines
optuna/integration/tensorboard.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
- Coverage   89.40%   89.38%   -0.03%     
==========================================
  Files         205      205              
  Lines       15160    15107      -53     
==========================================
- Hits        13554    13503      -51     
+ Misses       1606     1604       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HideakiImamura
Copy link
Copy Markdown
Member

HideakiImamura commented Dec 25, 2023

Thanks for the PR. Basically, LGTM. Could you apply the formatter? You can execute the formatter by running bash ./formats.sh after pip install -e ".[checking]".

By the way, we committers are now on vacation for the New Year's vacations. Therefore, the review may be delayed until the New Year. We apologize for any inconvenience.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 1, 2024

This pull request has not seen any recent activity.

@github-actions github-actions bot added stale Exempt from stale bot labeling. and removed stale Exempt from stale bot labeling. labels Jan 1, 2024
Copy link
Copy Markdown
Member

@not522 not522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! LGTM.
Note: The CI fail is not related this PR.

@not522 not522 added the compatibility Change that breaks compatibility. label Jan 4, 2024
@not522
Copy link
Copy Markdown
Member

not522 commented Jan 9, 2024

@HideakiImamura Could you review this PR?

@not522 not522 changed the title Delete tensorboard integration for migration to optuna-integration #4663 Delete tensorboard integration for migration to optuna-integration Jan 9, 2024
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit b8ff10b into optuna:master Jan 10, 2024
@HideakiImamura HideakiImamura added this to the v3.6.0 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants