Skip to content

Isolate the fast.ai module#5120

Merged
gen740 merged 1 commit intooptuna:masterfrom
sousu4:isolate_the_fast.ai_module
Nov 28, 2023
Merged

Isolate the fast.ai module#5120
gen740 merged 1 commit intooptuna:masterfrom
sousu4:isolate_the_fast.ai_module

Conversation

@sousu4
Copy link
Copy Markdown
Contributor

@sousu4 sousu4 commented Nov 17, 2023

Motivation

#4484 partry resolved.
On the Optuna side, I'm working on the fast.ai module .

Description of the changes

On the Optuna side, isolation the fast.ai module.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Nov 17, 2023
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ce4ad23) 89.30% compared to head (f2b3f9f) 89.43%.
Report is 3 commits behind head on master.

Files Patch % Lines
optuna/integration/fastaiv2.py 0.00% 3 Missing ⚠️
optuna/integration/fastaiv1.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5120      +/-   ##
==========================================
+ Coverage   89.30%   89.43%   +0.12%     
==========================================
  Files         205      205              
  Lines       15188    15140      -48     
==========================================
- Hits        13564    13540      -24     
+ Misses       1624     1600      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has not seen any recent activity.

@github-actions github-actions bot added the stale Exempt from stale bot labeling. label Nov 27, 2023
Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gen740 gen740 merged commit 58a87bc into optuna:master Nov 28, 2023
@gen740 gen740 added this to the v3.5.0 milestone Nov 28, 2023
@HideakiImamura HideakiImamura added compatibility Change that breaks compatibility. code-fix Change that does not change the behavior, such as code refactoring. and removed compatibility Change that breaks compatibility. labels Dec 8, 2023
@gen740 gen740 removed their assignment Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-fix Change that does not change the behavior, such as code refactoring. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. stale Exempt from stale bot labeling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants