Skip to content

Remove tensorflow integration#4666

Merged
toshihikoyanase merged 6 commits intooptuna:masterfrom
gen740:remove-tensorflow-integration
May 22, 2023
Merged

Remove tensorflow integration#4666
toshihikoyanase merged 6 commits intooptuna:masterfrom
gen740:remove-tensorflow-integration

Conversation

@gen740
Copy link
Copy Markdown
Member

@gen740 gen740 commented May 11, 2023

  • Motivation

Progress #4484

Description of the changes

  • Move integration/tensorflow.py and its test from optuna/optuna.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label May 11, 2023
@HideakiImamura HideakiImamura self-assigned this May 11, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #4666 (c6035c7) into master (4ef1a10) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4666      +/-   ##
==========================================
- Coverage   90.58%   90.57%   -0.01%     
==========================================
  Files         187      187              
  Lines       14346    14284      -62     
==========================================
- Hits        12995    12938      -57     
+ Misses       1351     1346       -5
Impacted Files Coverage Δ
optuna/integration/tensorflow.py 0.00% <0.00%> (-97.50%) ⬇️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Alnusjaponica
Alnusjaponica reviewed May 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems dependency on tensorflow-datasets can be removed too.

@HideakiImamura
Copy link
Copy Markdown
Member

HideakiImamura commented May 12, 2023

LGTM except @Alnusjaponica's comment.

HideakiImamura
HideakiImamura approved these changes May 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura removed their assignment May 15, 2023
@HideakiImamura HideakiImamura added the compatibility Change that breaks compatibility. label May 15, 2023
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone May 15, 2023
@HideakiImamura
Copy link
Copy Markdown
Member

HideakiImamura commented May 15, 2023

@Alnusjaponica Could you review this PR?

Alnusjaponica
Alnusjaponica requested changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will remove the following two lines:

@Alnusjaponica
Copy link
Copy Markdown
Contributor

Alnusjaponica commented May 17, 2023

Other than the changes mentioned above, LGTM.

Alnusjaponica
Alnusjaponica approved these changes May 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@HideakiImamura Could you merge this PR?

@Alnusjaponica Alnusjaponica removed their assignment May 20, 2023
@toshihikoyanase
Copy link
Copy Markdown
Member

toshihikoyanase commented May 22, 2023

This PR got two approvals. Let me merge it.

@toshihikoyanase toshihikoyanase merged commit 8c86672 into optuna:master May 22, 2023
@gen740 gen740 deleted the remove-tensorflow-integration branch June 2, 2023 06:02
@HideakiImamura HideakiImamura mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HideakiImamura HideakiImamura HideakiImamura approved these changes

@Alnusjaponica Alnusjaponica Alnusjaponica approved these changes

Assignees

No one assigned

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gen740 @codecov-commenter @HideakiImamura @Alnusjaponica @toshihikoyanase