Skip to content

Delete skorch integration for migration to optuna-integration#4663

Merged
HideakiImamura merged 5 commits intooptuna:masterfrom
eukaryo:move_skorch
May 11, 2023
Merged

Delete skorch integration for migration to optuna-integration#4663
HideakiImamura merged 5 commits intooptuna:masterfrom
eukaryo:move_skorch

Conversation

@eukaryo
Copy link
Copy Markdown
Collaborator

@eukaryo eukaryo commented May 11, 2023

Motivation

Progress #4484

Description of the changes

  • Move integration/skorch.py and its test from optuna/optuna.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label May 11, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2023

Codecov Report

Merging #4663 (6fb9b07) into master (72157df) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #4663      +/-   ##
==========================================
- Coverage   90.62%   90.60%   -0.02%     
==========================================
  Files         185      185              
  Lines       14021    14000      -21     
==========================================
- Hits        12706    12685      -21     
  Misses       1315     1315
Impacted Files Coverage Δ
optuna/integration/skorch.py 0.00% <0.00%> (-91.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

contramundum53
contramundum53 approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@contramundum53
Copy link
Copy Markdown
Member

contramundum53 commented May 11, 2023

@HideakiImamura Could you review this PR?

@gen740 gen740 mentioned this pull request May 11, 2023
Closed
HideakiImamura
HideakiImamura approved these changes May 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit 557f079 into optuna:master May 11, 2023
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone May 11, 2023
@HideakiImamura HideakiImamura added the compatibility Change that breaks compatibility. label May 11, 2023
@eukaryo eukaryo deleted the move_skorch branch September 6, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@contramundum53 contramundum53 contramundum53 approved these changes

@HideakiImamura HideakiImamura HideakiImamura approved these changes

Assignees

@HideakiImamura HideakiImamura

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eukaryo @codecov-commenter @contramundum53 @HideakiImamura