Remove tf.keras integration.#4662
Merged
HideakiImamura merged 2 commits intooptuna:masterfrom May 12, 2023
Merged
Conversation
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the comment. I have two minor comments. PTAL.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #4662 +/- ##
==========================================
- Coverage 90.62% 90.59% -0.03%
==========================================
Files 185 185
Lines 14021 13997 -24
==========================================
- Hits 12706 12681 -25
- Misses 1315 1316 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
All CI jobs passed. PTAL. |
Member
Author
|
@Alnusjaponica We talked about this PR offline, and you may be interested in it. Do you have time to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a part of #4484.
It removes
tf.kerasintegration, and optuna/optuna-integration#21 will add it to theoptuna_integrationpackage.Description of the changes
optuna.integration.TFKerasPruningCallbackand its tests.