Get system_attrs lazily for samplers and pruners#4603
Closed
not522 wants to merge 2 commits intooptuna:masterfrom
Closed
Get system_attrs lazily for samplers and pruners#4603not522 wants to merge 2 commits intooptuna:masterfrom
system_attrs lazily for samplers and pruners#4603not522 wants to merge 2 commits intooptuna:masterfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #4603 +/- ##
==========================================
+ Coverage 90.79% 90.96% +0.17%
==========================================
Files 187 183 -4
Lines 13932 13925 -7
==========================================
+ Hits 12649 12667 +18
+ Misses 1283 1258 -25
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7ff4b7d to
1c97089
Compare
c-bata
reviewed
Apr 18, 2023
Member
c-bata
left a comment
There was a problem hiding this comment.
My initial impression is that changes look almost perfect to me. Let me check the performance of _CachedStorage with this change.
Member
|
@gen740 Could you review this PR, please? |
Member
Author
|
This PR was taken over by #4631. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is part of the work to deprecate
_CachedStorage.When directly using
RDBStorage,_get_latest_trialis a bottleneck because it readssystem_attrsfrom the remote storage.Description of the changes
Getting
system_attrslazily. This change eliminates access to remote storage forsystem_attrsby samplers and pruners exceptGridSampler,SuccessiveHalvingPruner, andHyperbandPruner.