Skip to content

Delete AllenNLP integration for migration to optuna-integration#4579

Merged
HideakiImamura merged 1 commit intooptuna:masterfrom
Alnusjaponica:remove-integration-allennlp
Apr 7, 2023
Merged

Delete AllenNLP integration for migration to optuna-integration#4579
HideakiImamura merged 1 commit intooptuna:masterfrom
Alnusjaponica:remove-integration-allennlp

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

Motivation

Progress #4484

Description of the changes

  • Delete AllenNLP related implementation and tests.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Apr 5, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #4579 (e6b67f1) into master (1599d23) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           master    #4579    +/-   ##
========================================
  Coverage   90.79%   90.79%            
========================================
  Files         187      182     -5     
  Lines       13932    13688   -244     
========================================
- Hits        12649    12428   -221     
+ Misses       1283     1260    -23     
Impacted Files Coverage Δ
optuna/integration/allennlp/__init__.py 0.00% <0.00%> (-100.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Alnusjaponica Alnusjaponica marked this pull request as ready for review April 5, 2023 02:58
@Alnusjaponica Alnusjaponica changed the title Remove allennlp Delete AllenNLP integration for migration to optuna-integration Apr 5, 2023
@contramundum53
Copy link
Copy Markdown
Member

@HideakiImamura @gen740 Could you review this PR?

Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit cb80334 into optuna:master Apr 7, 2023
@HideakiImamura HideakiImamura added the compatibility Change that breaks compatibility. label Apr 7, 2023
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone Apr 7, 2023
@Alnusjaponica Alnusjaponica deleted the remove-integration-allennlp branch April 7, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants