Skip to content

Delete optuna.integration.KerasPruningCallback for migration to optuna-integration#4558

Merged
HideakiImamura merged 2 commits intooptuna:masterfrom
Alnusjaponica:remove-integration-keras
Apr 7, 2023
Merged

Delete optuna.integration.KerasPruningCallback for migration to optuna-integration#4558
HideakiImamura merged 2 commits intooptuna:masterfrom
Alnusjaponica:remove-integration-keras

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica commented Mar 30, 2023

Motivation

Progress #4484

Description of the changes

  • Delete optuna.integration.KerasPruningCallback implementation and tests.

@github-actions github-actions bot added the optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions. label Mar 30, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 30, 2023

Codecov Report

Merging #4558 (5873ccf) into master (01aa6d9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #4558      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.03%     
==========================================
  Files         187      187              
  Lines       13936    13907      -29     
==========================================
- Hits        12652    12622      -30     
- Misses       1284     1285       +1
Impacted Files Coverage Δ
optuna/integration/keras.py 0.00% <0.00%> (-96.78%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gen740 gen740 self-assigned this Mar 31, 2023
@gen740 gen740 mentioned this pull request Mar 31, 2023
Closed
@Alnusjaponica Alnusjaponica marked this pull request as ready for review March 31, 2023 08:36
@gen740
Copy link
Copy Markdown
Member

gen740 commented Apr 5, 2023

@HideakiImamura Could you review this PR?

gen740
gen740 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@gen740 gen740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HideakiImamura
HideakiImamura approved these changes Apr 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit d1333aa into optuna:master Apr 7, 2023
@HideakiImamura HideakiImamura added this to the v3.2.0 milestone Apr 7, 2023
@HideakiImamura HideakiImamura added the compatibility Change that breaks compatibility. label Apr 7, 2023
@Alnusjaponica Alnusjaponica deleted the remove-integration-keras branch April 7, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HideakiImamura HideakiImamura HideakiImamura approved these changes

@gen740 gen740 gen740 approved these changes

Assignees

@HideakiImamura HideakiImamura

@gen740 gen740

Labels

compatibility Change that breaks compatibility. optuna.integration Related to the `optuna.integration` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Alnusjaponica @codecov-commenter @gen740 @HideakiImamura