Delete optuna.integration.ChainerPruningExtension for migrating to optuna-integration package.#4370
Merged
contramundum53 merged 15 commits intooptuna:masterfrom Feb 28, 2023
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #4370 +/- ##
==========================================
- Coverage 90.40% 89.66% -0.74%
==========================================
Files 172 178 +6
Lines 13682 13937 +255
==========================================
+ Hits 12369 12497 +128
- Misses 1313 1440 +127
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
This pull request has not seen any recent activity. |
07aa32d to
630c31b
Compare
Contributor
|
This pull request has not seen any recent activity. |
a8afbe6 to
18ae762
Compare
18ae762 to
5adf45d
Compare
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have several comments.
contramundum53
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Optuna.integrationis a cluster of the integration modules that are independent of each other.So splitting optuna-integraton into another module will reduce the cost of development.
I have made a prototype of
optuna-integraton,which only contains
optuna.integration.ChainerPruningExtension.In this PR, I delete the
optuna.integration.ChainerPruningExtensionfor theoptuna-integrationmodule.Description of the changes
optuna.integration.ChainerPruningExtensionimplementation and tests.