Merged
Conversation
Add lock_obj argument
Apply review feedbacks
c-bata
reviewed
Aug 30, 2022
c-bata
reviewed
Aug 30, 2022
c-bata
reviewed
Aug 30, 2022
c-bata
reviewed
Aug 30, 2022
c-bata
reviewed
Aug 30, 2022
Member
c-bata
left a comment
There was a problem hiding this comment.
Thank you for your pull request. Changes almost looks good to me.
I wrote some minor review comments.
c-bata
reviewed
Aug 30, 2022
Member
|
Please merge the master branch to fix CI failures after #3950 is merged. |
keisuke-umezawa
approved these changes
Aug 31, 2022
Member
keisuke-umezawa
left a comment
There was a problem hiding this comment.
Thank you for updating it. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce JournalStorage to optuna.
Journal storage writes a record of every operation to the database as it is executed and at the same time, keeps a latest snapshot of the database in-memory. If the database crashes for any reason, the storage can re-establish the contents in memory by replaying the operations stored from the beginning.
Journal storage has several benefits over the conventional value logging storages.
BaseJournalLogStorage) has a simpler backend API than the conventional storage (BaseStorage), which makes it easier to plug-in other backend implementations.Description of the changes
optuna/storages/_journal/storage.pyBaseStoragenamed asJournalStorage.optuna/storages/_journal/base.pyJournalStoragebackend named asBaseJournalLogStorage.optuna/storages/_journal/file.pyBaseJournalLogStoragenamed asJournalFileLogStorage. This file also contains implementations of locks needed for synchronizing processes.tests/storages_tests/test_journal.pyJournalFileLogStorage.References