Update warning message and add a test when a trial fails with exception#3454
Merged
not522 merged 2 commits intooptuna:masterfrom Apr 25, 2022
Merged
Update warning message and add a test when a trial fails with exception#3454not522 merged 2 commits intooptuna:masterfrom
not522 merged 2 commits intooptuna:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 157 157
Lines 12317 12319 +2
=======================================
+ Hits 11315 11317 +2
Misses 1002 1002
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
|
@not522 Could you review this PR? |
HideakiImamura
approved these changes
Apr 12, 2022
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good to me. (The STUDY_TELL_WARNING_KEY = "STUDY_TELL_WARNING" is introduced, and it is different from the previous one "study_tell_warning". But, the lifetime of the STUDY_TELL_WARNING_KEY for each trial is closed from the tell to the finally close, so it seems not to be a concern.)
Member
Author
|
Let me kindly ping @not522. 🙋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #3144.
Description of the changes
_run_trialtostudy.tell#3144 (comment)_run_trialtostudy.tell#3144 (review)Trial's system attributes. But I'm not sure it is needed sinceset_system_attris invoked forFrozenTrial