Avoid latest PyTorch lightning until integration is updated#3417
Merged
HideakiImamura merged 1 commit intooptuna:masterfrom Mar 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3417 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 156 156
Lines 12262 12262
=======================================
Hits 11257 11257
Misses 1005 1005 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
Author
|
@himkt thanks for the self assignment, let me know if you have any concerns with this change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Temporarily avoid the latest pytorch-lightning 1.6.0 to circumvent CI failures in the
masterbranch.A proper fix involves updating
PyTorchLightningPruningCallback, preferably not to use private APIs.Failure: https://github.com/optuna/optuna/runs/5745775785?check_suite_focus=true
Release note: https://github.com/PyTorchLightning/pytorch-lightning/releases/tag/1.6.0
Description of the changes
See above.