Added unit tests for contour of matplotlib tests#2806
Merged
hvy merged 1 commit intooptuna:masterfrom Jul 19, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2806 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 146 146
Lines 11150 11150
=======================================
Hits 10227 10227
Misses 923 923 Continue to review full report at Codecov.
|
8 tasks
nzw0301
approved these changes
Jul 14, 2021
Member
nzw0301
left a comment
There was a problem hiding this comment.
As always, the pull request looks great to me! Thanks!
Merged
4 tasks
hvy
approved these changes
Jul 19, 2021
Member
hvy
left a comment
There was a problem hiding this comment.
Thanks a lot. I left a minor comment but this change is an improvement and there are seemingly other PRs waiting for this change, so let me merge this PR as is. LGTM!
| assert not figure.has_data() | ||
| assert len(figure.get_lines()) == 0 | ||
| elif len(params) == 2: | ||
| # TODO(ytknzw): Add more specific assertion with the test case. |
Member
There was a problem hiding this comment.
I'm wondering if this TODO isn't still applicable but it's a minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Added more test cases to
optuna/visualization/matplotlib/test_contour.pycloses #2643
Description of the changes