Skip to content

Changed unit tests for parallel coordinate of matplotlib tests#2778

Merged
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-parallel-coordinate-2643
Jul 6, 2021
Merged

Changed unit tests for parallel coordinate of matplotlib tests#2778
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-parallel-coordinate-2643

Conversation

@01-vyom
Copy link
Copy Markdown
Contributor

@01-vyom 01-vyom commented Jul 2, 2021

Motivation

Changed test cases for optuna/visualization/matplotlib/test_parallel_coordinate.py
xref #2643

Description of the changes

  • Checked number of lines

Copy link
Copy Markdown
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzw0301 nzw0301 added the test Unit test. label Jul 4, 2021
@Crissman Crissman self-assigned this Jul 5, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2778 (081e718) into master (10a9dfe) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
+ Coverage   91.67%   91.69%   +0.01%     
==========================================
  Files         140      140              
  Lines       11072    11072              
==========================================
+ Hits        10150    10152       +2     
+ Misses        922      920       -2     
Impacted Files Coverage Δ
optuna/integration/botorch.py 98.65% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a9dfe...081e718. Read the comment docs.

Copy link
Copy Markdown
Contributor

@Crissman Crissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crissman Crissman merged commit 88c4987 into optuna:master Jul 6, 2021
@Crissman Crissman added this to the v2.9.0 milestone Jul 6, 2021
@01-vyom 01-vyom deleted the test-parallel-coordinate-2643 branch July 6, 2021 03:46
@hvy hvy changed the title TST: Changed unit tests for parallel coordinate of matplotlib tests Changed unit tests for parallel coordinate of matplotlib tests Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants