Added unit tests for param importances of matplotlib tests#2774
Merged
Crissman merged 3 commits intooptuna:masterfrom Jul 6, 2021
Merged
Added unit tests for param importances of matplotlib tests#2774Crissman merged 3 commits intooptuna:masterfrom
Crissman merged 3 commits intooptuna:masterfrom
Conversation
8 tasks
nzw0301
approved these changes
Jul 4, 2021
Member
nzw0301
left a comment
There was a problem hiding this comment.
Like always, your PR looks great to me. Thank you for your many contributions.
Member
|
Could you merge the master branch to fix the CI errors? |
Codecov Report
@@ Coverage Diff @@
## master #2774 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 140 140
Lines 11072 11072
=======================================
Hits 10150 10150
Misses 922 922 Continue to review full report at Codecov.
|
Crissman
approved these changes
Jul 6, 2021
Contributor
Crissman
left a comment
There was a problem hiding this comment.
Thanks for another test enhancement. 🙇 Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Added more test cases to
optuna/visualization/matplotlib/test_param_importances.pyxref #2643
Description of the changes