Skip to content

Added unit tests for slice of matplotlib tests#2764

Merged
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-slice-2643
Jul 6, 2021
Merged

Added unit tests for slice of matplotlib tests#2764
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-slice-2643

Conversation

@01-vyom
Copy link
Copy Markdown
Contributor

@01-vyom 01-vyom commented Jun 27, 2021

Motivation

Added more test cases to optuna/visualization/matplotlib/test_slice.py
xref #2643

Description of the changes

  • Checked number of lines
  • Checked title of figure
  • Checked label of figure

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2764 (af16cfe) into master (968ca6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2764   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         140      140           
  Lines       11342    11342           
=======================================
  Hits        10395    10395           
  Misses        947      947           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968ca6b...af16cfe. Read the comment docs.

Copy link
Copy Markdown
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for adding checks for labels.

@nzw0301 nzw0301 self-assigned this Jun 28, 2021
@hvy
Copy link
Copy Markdown
Member

hvy commented Jun 29, 2021

Ditto #2763 (comment).

Copy link
Copy Markdown
Contributor

@Crissman Crissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@Crissman Crissman merged commit 257a287 into optuna:master Jul 6, 2021
@Crissman Crissman added this to the v2.9.0 milestone Jul 6, 2021
@01-vyom 01-vyom deleted the test-slice-2643 branch July 6, 2021 03:47
@hvy hvy changed the title TST: Added unit tests for slice of matplotlib tests Added unit tests for slice of matplotlib tests Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants