Skip to content

Added unit tests for optimization history of matplotlib tests#2761

Merged
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-optimization-history-2643
Jun 28, 2021
Merged

Added unit tests for optimization history of matplotlib tests#2761
Crissman merged 2 commits intooptuna:masterfrom
01-vyom:test-optimization-history-2643

Conversation

@01-vyom
Copy link
Copy Markdown
Contributor

@01-vyom 01-vyom commented Jun 25, 2021

Motivation

Added more test cases to optuna/visualization/matplotlib/test_optimization_history.py
xref #2643

Description of the changes

  • Checked number of lines
  • Checked title of figure
  • Checked data values

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2761 (36c0077) into master (968ca6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2761   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         140      140           
  Lines       11342    11342           
=======================================
  Hits        10395    10395           
  Misses        947      947           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968ca6b...36c0077. Read the comment docs.

@nzw0301
Copy link
Copy Markdown
Member

nzw0301 commented Jun 28, 2021

Could you merge the master branch into your branch to fix the error of Checks?

@hvy
Copy link
Copy Markdown
Member

hvy commented Jun 28, 2021

@nzw0301, @Crissman could you have a look at this PR?

Copy link
Copy Markdown
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your pull request.

Copy link
Copy Markdown
Contributor

@Crissman Crissman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging!

@Crissman Crissman merged commit 6ca15bb into optuna:master Jun 28, 2021
@Crissman Crissman added this to the v2.9.0 milestone Jun 28, 2021
@01-vyom 01-vyom deleted the test-optimization-history-2643 branch June 28, 2021 17:23
@hvy hvy changed the title TST: Added unit tests for optimization history of matplotlib tests Added unit tests for optimization history of matplotlib tests Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Unit test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants