Add specific test cases for visualization.matplotlib.plot_intermediate_values#2754
Merged
nzw0301 merged 1 commit intooptuna:masterfrom Jul 14, 2021
Conversation
Contributor
|
@keisuke-umezawa Can you take a look at this? |
Crissman
approved these changes
Jun 23, 2021
Contributor
Crissman
left a comment
There was a problem hiding this comment.
Thank you for the PR! LGTM.
8 tasks
nzw0301
requested changes
Jul 7, 2021
Member
|
cc: @asquare100 |
nzw0301
approved these changes
Jul 14, 2021
Member
nzw0301
left a comment
There was a problem hiding this comment.
Basically, the change looks great to me except for my comment. Since we do not get an update, let me merge this PR. I'll send a follow-up PR later.
visualization.matplotlib.plot_intermediate_values
Member
|
Let me rename the PR title with a more informative one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, test cases in
optuna/visualization/matplotlib/*.pyare not enough compared tooptuna/visualization/*.py.Fixes
Issue
Description of the changes
In this PR, I have added some specific test cases to the file
tests/visualization_tests/matplotlib/test_intermediate_plot.py.I will be creating another PR to add test cases in other files of
tests/visualization_tests/matplotlib/