Add test cases in optuna/visualization/matplotlib/edf.py#2642
Merged
nzw0301 merged 1 commit intooptuna:masterfrom May 6, 2021
keisuke-umezawa:feature/add-test-case-matplotlib
Merged
Add test cases in optuna/visualization/matplotlib/edf.py#2642nzw0301 merged 1 commit intooptuna:masterfrom keisuke-umezawa:feature/add-test-case-matplotlib
optuna/visualization/matplotlib/edf.py#2642nzw0301 merged 1 commit intooptuna:masterfrom
keisuke-umezawa:feature/add-test-case-matplotlib
Conversation
8 tasks
hvy
approved these changes
May 6, 2021
Member
hvy
left a comment
There was a problem hiding this comment.
Thanks a lot, LGTM!
The x-axis label could actually be checked in all cases since it's always present but this seems consistent with the plotly unit tests. Again, thanks!
Member
|
@nzw0301 would you like to jump in as a second reviewer? |
Member
|
The unrelated CI failures should be fixed in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add more test cases similar to
optuna/visualization/matplotlib/edf.pyDescription of the changes