Store CMAES optimizer after splitting into substrings.#1833
Store CMAES optimizer after splitting into substrings.#1833hvy merged 8 commits intooptuna:masterfrom
Conversation
|
I prepare a script to reproduce the bug and confirmed that this PR fixed it. Before: After: And I also confirmed that this change has no effect to optimization results. See https://gist.github.com/c-bata/28a6334c37f340a2ce8e54c4dee1e2bf#gistcomment-3454630 for details. |
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is an amazing alternative to PR #1776. The changes look great to me.
hvy
left a comment
There was a problem hiding this comment.
Thanks for the interesting PR. Basically LGTM! I left some questions rather than request if you don't mind.
|
By the way, I for a moment though about providing this splitting under hood of the |
|
FYI, 2048 character limits is just an implementation detail on RDBStorage, not a specification of BaseStorage. So I think we have two options:
I prefer the former approach, but it contains a breaking change (though it's an undefined behavior). |
|
Let's discuss #1833 (comment) further. I'll create a separate issue for it. |
Motivation
fix #1775
Description of the changes
Split an optimizer string, puts these substrings into system_attrs.