Prefer math.log with base argument in HyperbandPruner.#1182
Closed
hvy wants to merge 1 commit intooptuna:masterfrom
Closed
Prefer math.log with base argument in HyperbandPruner.#1182hvy wants to merge 1 commit intooptuna:masterfrom
math.log with base argument in HyperbandPruner.#1182hvy wants to merge 1 commit intooptuna:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 142 142
Lines 12276 12276
=======================================
Hits 11174 11174
Misses 1102 1102
Continue to review full report at Codecov.
|
Member
Author
|
Let me close this PR as it most likely will be included in #1188. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Simple is better than complex. (It's also faster as it's implemented in C, https://github.com/python/cpython/blob/master/Modules/mathmodule.c#L2347.)
Description of the changes
Make use of the second argument in
math.logfor a non-trivial base.