Skip to content

Add figure title to contour plot#1181

Merged
toshihikoyanase merged 2 commits intooptuna:masterfrom
harupy:add-title-to-contour-plot
May 1, 2020
Merged

Add figure title to contour plot#1181
toshihikoyanase merged 2 commits intooptuna:masterfrom
harupy:add-title-to-contour-plot

Conversation

@harupy
Copy link
Copy Markdown
Contributor

@harupy harupy commented Apr 28, 2020

Motivation

Resolves #1176

Description of the changes

  • Add a figure title to the contour plot.
  • Update plot_contour.html.

@harupy
Copy link
Copy Markdown
Contributor Author

harupy commented Apr 28, 2020 •
edited
Loading

Screen Shot 2020-04-28 at 21 03 16

https://38688-122299416-gh.circle-artifacts.com/0/docs/build/html/reference/visualization.html#optuna.visualization.plot_contour

@c-bata
Copy link
Copy Markdown
Member

c-bata commented Apr 28, 2020

Hi, thank you for your pull request! Actually, I once added a similar argument to call update_layout() at #704. But it was reverted and made plot functions just return Plotly's figure object for flexibility.

The same discussion seems to be applied to this pull request. What do you think?
cc: @himkt @toshihikoyanase

@harupy
Copy link
Copy Markdown
Contributor Author

harupy commented Apr 28, 2020 •
edited
Loading

@c-bata Thanks for the comment! Is 463a52d the commit you're taking about?

@toshihikoyanase
Copy link
Copy Markdown
Member

toshihikoyanase commented Apr 28, 2020

@c-bata Thank you for your comment.
This PR uses the update_layout function, but I think it applies a layout generated inside the _get_contour_plot method, not layouts given by users. So, I think the situation is not the same as #704. Please let me know if I have misunderstood your comment.

@toshihikoyanase toshihikoyanase added optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions. bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. labels Apr 28, 2020
@toshihikoyanase toshihikoyanase self-assigned this Apr 28, 2020
@c-bata
Copy link
Copy Markdown
Member

c-bata commented Apr 30, 2020 •
edited
Loading

@toshihikoyanase Ah, you are right. I misunderstood the change. Thanks.

c-bata
c-bata approved these changes Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@c-bata c-bata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harupy Sorry for my late reply. LGTM. Thank you for your contribution!

toshihikoyanase
toshihikoyanase approved these changes May 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@toshihikoyanase toshihikoyanase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your constant contribution.

@toshihikoyanase toshihikoyanase added this to the v1.4.0 milestone May 1, 2020
@toshihikoyanase toshihikoyanase merged commit dc8207d into optuna:master May 1, 2020
@harupy harupy deleted the add-title-to-contour-plot branch May 1, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toshihikoyanase toshihikoyanase toshihikoyanase approved these changes

@c-bata c-bata c-bata approved these changes

Assignees

@toshihikoyanase toshihikoyanase

Labels

bug Issue/PR about behavior that is broken. Not for typos/examples/CI/test but for Optuna itself. optuna.visualization Related to the `optuna.visualization` submodule. This is automatically labeled by github-actions.

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

Show title in figure for contour plot.

3 participants

@harupy @c-bata @toshihikoyanase