Support Copy-on-Write for thread safety in in-memory storage.#1139
Merged
hvy merged 1 commit intooptuna:masterfrom Apr 27, 2020
Merged
Support Copy-on-Write for thread safety in in-memory storage.#1139hvy merged 1 commit intooptuna:masterfrom
hvy merged 1 commit intooptuna:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
=========================================
Coverage ? 90.41%
=========================================
Files ? 128
Lines ? 11203
Branches ? 0
=========================================
Hits ? 10129
Misses ? 1074
Partials ? 0
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since optuna internals are assumed to work in a copy-on-write manner, samplers and others access to trials without deep-copy. However, the in-memory storage class actually does not follow a copy-on-write fashion.
While I did not check every sampler/study logics, the missing copy can result in untractable bugs under multi-thread settings.
This PR implements the missing copy-on-write logics for in-memory storage.