feat: don't return Ultra Quality to real DLSS#80
Merged
Conversation
d900959 to
81ccaee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the NVIDIA docs, game devs are expected to check if a given PerfQuality mode is enabled for a DLSS version by calling NVSDK_NGX_DLSS_GetOptimalSettingsCallback and checking if the the OptimalWidth/OptimalHeight > 0.
Satisfactory does that, and if it's present, it will try to use NVSDK_NGX_PerfQuality_Value_UltraQuality as a mode for ANY DLSS mode that isn't DLAA.
This causes the real DLSS runtime to throw an error on feature creation when used with OptiScaler, and this PR fixes that by returning that Ultra Quality isn't available when the real DLSS is enabled.