fix: Add six dependency to requirements/core.txt#363
Merged
The-inside-man merged 3 commits intomasterfrom Dec 7, 2021
Merged
Conversation
… is used in the core sdk functionality.
msohailhussain
approved these changes
Nov 18, 2021
Contributor
msohailhussain
left a comment
There was a problem hiding this comment.
lgtm. per our discussion need to add description in the summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note: This library is used throughout the core functionality of the SDK, however the build did not fail previously due to the six library being a transient dependency for jsonschema. Jsonschema is already in requirements/core.txt, however, we are now choosing to explicitly require the six dependency as we use this library explicitly in our SDK.
Test plan
Issues