Closed
Conversation
tests/test_user_context.py
Outdated
| @@ -0,0 +1,34 @@ | |||
| # Copyright 2019, Optimizely | |||
optimizely/user_context.py
Outdated
| @@ -0,0 +1,84 @@ | |||
| # | |||
jaeopt
requested changes
Dec 9, 2020
Contributor
jaeopt
left a comment
There was a problem hiding this comment.
Looks good.
Should add mutex control for attributes. More tests suggested.
| Returns: | ||
| None | ||
| """ | ||
| self.user_attributes[attribute_key] = attribute_value |
Contributor
There was a problem hiding this comment.
Can we add a mutex control for attributes read/write?
"setAttributes" and attribute -reading for decide can happen in other threads. See C#-sdk as a good reference (optimizely/csharp-sdk#253)
| uc.set_attribute("key", "value") | ||
| self.assertEqual(uc.user_attributes["key"], "value", "should have added attribute") | ||
| uc.set_attribute("key", "value2") | ||
| self.assertEqual(uc.user_attributes["key"], "value2", "should have new attribute") |
Contributor
There was a problem hiding this comment.
Can we have more tests:
- construct with non-empty attributes
- setAttribute can override the init attributes
- attributes not changed once constructed when the caller copy is updated
Contributor
|
Merged with #309 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests added