(fix): refactor batch_event_processor to reset deadline after it passes. #227
Merged
thomaszurkan-optimizely merged 11 commits intomasterfrom Dec 14, 2019
Merged
(fix): refactor batch_event_processor to reset deadline after it passes. #227thomaszurkan-optimizely merged 11 commits intomasterfrom
thomaszurkan-optimizely merged 11 commits intomasterfrom
Conversation
…o, hang on queue with timeout at flush interval
1 similar comment
Contributor
|
Fix looks fine to me. Do we need additional unit tests for this fix? |
aliabbasrizvi
approved these changes
Dec 13, 2019
Contributor
aliabbasrizvi
left a comment
There was a problem hiding this comment.
Synced with Tom and Mike on this. Changes make sense.
LGTM
| """ | ||
| if _time is None: | ||
| return int(round(time.time())) | ||
| return time.time() |
Contributor
There was a problem hiding this comment.
Please change the description of the method.
Also Returns, valid time, can be float and integer. Need to revise documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, hang on queue with timeout at flush interval
Summary
Test plan
Current tests should pass
Issues