Implement get_feature_variable and create unit tests#191
Merged
brandonhudavid merged 12 commits intomasterfrom Jul 24, 2019
Merged
Implement get_feature_variable and create unit tests#191brandonhudavid merged 12 commits intomasterfrom
brandonhudavid merged 12 commits intomasterfrom
Conversation
mikeproeng37
approved these changes
Jul 24, 2019
Contributor
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm, thanks for the thorough unit test coverage. Good to go once you take up @aliabbasrizvi on his suggestion 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_feature_variablemethod to return value of variable with any typeget_feature_variablePython is a dynamically-typed language, like JavaScript, so it suffices to have a single method return the value of a feature variable rather than have a separate method for each possible feature variable type.
Test plan
Issues