fix(track): Send decisions for all experiments using an event when using track#136
Merged
aliabbasrizvi merged 6 commits intomasterfrom Aug 21, 2018
Merged
Conversation
Contributor
Author
|
build-e2e |
Contributor
Author
|
This includes commits from #135 |
optimizely/event_builder.py
Outdated
| event_dict[self.EventParams.TAGS] = event_tags | ||
|
|
||
| return snapshot | ||
| snapshot.setdefault(self.EventParams.EVENTS, []).append(event_dict) |
Contributor
There was a problem hiding this comment.
Do we need to setdefault as opposed to just initializing an empty array with that event_dict?
Contributor
Author
There was a problem hiding this comment.
Yeah, let me update that.
| } | ||
|
|
||
| self.optimizely = optimizely.Optimizely(json.dumps(self.config_dict)) | ||
| self.config_dict_with_multiple_experiments = { |
Contributor
There was a problem hiding this comment.
Shouldn't this be passed in for that one unit test that uses it?
Contributor
Author
There was a problem hiding this comment.
I think it is ok
mikeproeng37
approved these changes
Aug 21, 2018
Contributor
mikeproeng37
left a comment
There was a problem hiding this comment.
I left some comments, mostly nits
Contributor
Author
|
build-e2e |
Contributor
|
build-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.