Run post-build after all other plugins#23
Merged
oprypin merged 1 commit intooprypin:masterfrom Apr 27, 2023
Merged
Conversation
Owner
|
And released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mkdocs-gen-files deletes its temporary directory during the
post_buildevent, but some other plugins like mkdocs-i18n use the files generated during this event as well, but also require them to be generated beforehand (during theon_filesevent).While it is still possible to place the plugin at the top of the
mkdocsplugins list to solve theon_filesdependency, this also results in the cleanup being run first. Fortunately, as of mkdocs 1.4, we can order the execution of events with theevent_prioritydecorator.This PR proposes to decorate the
on_post_buildmethod so that it always executes last.