Use GHA for python#6444
Merged
Merged
Conversation
The path where python 3.8 was expected does not exist, the tests were using the installed python instead. With this change the expected python version will be used for installation of packages through pip as well as the execution of ansible or molecule will use the expected python version. Signed-off-by: Tony Garcia <tonyg@redhat.com>
83bb207 to
d308c69
Compare
grokspawn
approved these changes
May 23, 2023
grokspawn
left a comment
Contributor
There was a problem hiding this comment.
Thanks @tonyskapunk for the PR! Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
The path where python 3.8 was expected does not exist, the tests were using the installed python instead. With this change the expected python version will be used for installation of packages through pip as well as the execution of ansible or molecule will use the expected python version.
Motivation for the change:
Should help to fix issue #6433
In this test (line 123) I could see there's nothing in
/opt/pythonin the GH runner.Even when the runner images should provide older versions of python, it is recommended to use the GHA for it
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs