Skip to content

enable ginkgolinter and fix findings#6421

Merged
grokspawn merged 1 commit into
operator-framework:masterfrom
nunnatsa:enable-ginkgolinter
May 18, 2023
Merged

enable ginkgolinter and fix findings#6421
grokspawn merged 1 commit into
operator-framework:masterfrom
nunnatsa:enable-ginkgolinter

Conversation

@nunnatsa

@nunnatsa nunnatsa commented May 6, 2023

Copy link
Copy Markdown
Contributor

Description of the change

enable ginkgolinter and fix findings.

Motivation for the change

Improve test code quality and prevent some bug, when using ginkgo and gomega.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci Bot requested review from grokspawn and oceanc80 May 6, 2023 09:18
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 11, 2023 18:17 — with GitHub Actions Inactive
varshaprasad96
varshaprasad96 approved these changes May 11, 2023
View reviewed changes

@varshaprasad96 varshaprasad96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@varshaprasad96

varshaprasad96 commented May 11, 2023

Copy link
Copy Markdown
Member

@nunnatsa looks like the scorecard tests are failing. At a glance looks like the changes in scorecard/ files is as expected. This may also be a flake, hence restarting the tests.

@nunnatsa

nunnatsa commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

@varshaprasad96 thsnks. I think this test is broken. It constantly fails in my other pr, and also locally from the master branch.

everettraven
everettraven approved these changes May 15, 2023
View reviewed changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @nunnatsa! All the changes look good to me!

/lgtm

@nunnatsa nunnatsa force-pushed the enable-ginkgolinter branch from ad8e3aa to 6e70778 Compare May 16, 2023 13:59
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@nunnatsa

nunnatsa commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

@grokspawn @varshaprasad96 @everettraven - rebased to unblock the CI. Could you please approve again?

@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 16, 2023 14:29 — with GitHub Actions Inactive
everettraven
everettraven approved these changes May 16, 2023
View reviewed changes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven everettraven temporarily deployed to deploy May 16, 2023 16:42 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 16, 2023 16:43 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 16, 2023 16:43 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 16, 2023 16:44 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 16, 2023 16:45 — with GitHub Actions Inactive
@nunnatsa

nunnatsa commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

Not sure closing and reopening is enough. I'll rebase

@everettraven

everettraven commented May 16, 2023

Copy link
Copy Markdown
Contributor

@nunnatsa Closing and reopening worked. The current failures are unrelated and shouldn't block this PR

@everettraven

everettraven commented May 16, 2023

Copy link
Copy Markdown
Contributor

For reference on the failing tests, I created separate issues to track their fixes (#6434 + #6433) and suggest that for the time being we override them where it makes sense

@nunnatsa
enable ginkgolinter and fix findings
909a688 
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa nunnatsa force-pushed the enable-ginkgolinter branch from 6e70778 to 909a688 Compare May 16, 2023 17:27
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 16, 2023
@openshift-ci

openshift-ci Bot commented May 16, 2023

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@nunnatsa

nunnatsa commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

rebased anyway. @everettraven - sorry - missed your coment.

@nunnatsa

nunnatsa commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

@varshaprasad96, @grokspawn - could you please take another look?

@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 18, 2023 12:24 — with GitHub Actions Inactive
@grokspawn

grokspawn commented May 18, 2023

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 18, 2023
@grokspawn

grokspawn commented May 18, 2023

Copy link
Copy Markdown
Contributor

/override ansible/e2e-molecule
/override sanity/docs

These are unrelated; tracked separately by #6433 and #6434

@openshift-ci

openshift-ci Bot commented May 18, 2023

Copy link
Copy Markdown

@grokspawn: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ansible/e2e-molecule
  • sanity/docs

Only the following failed contexts/checkruns were expected:

  • DCO
  • docs
  • e2e
  • e2e-molecule
  • goreleaser
  • integration
  • netlify/operator-sdk/deploy-preview
  • unit

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ansible/e2e-molecule
/override sanity/docs

These are unrelated; tracked separately by #6433 and #6434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn

grokspawn commented May 18, 2023

Copy link
Copy Markdown
Contributor

/override docs
/override e2e-molecule

(see above)

@openshift-ci

openshift-ci Bot commented May 18, 2023

Copy link
Copy Markdown

@grokspawn: Overrode contexts on behalf of grokspawn: docs, e2e-molecule

Details

In response to this:

/override docs
/override e2e-molecule

(see above)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn grokspawn merged commit 5a1acbf into operator-framework:master May 18, 2023
@nunnatsa

nunnatsa commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

🎉

@nunnatsa nunnatsa deleted the enable-ginkgolinter branch May 18, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@grokspawn grokspawn grokspawn approved these changes

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@everettraven everettraven

@varshaprasad96 varshaprasad96

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nunnatsa @varshaprasad96 @everettraven @grokspawn