Skip to content

Update OLM version to 0.24.0#6362

Merged
oceanc80 merged 1 commit into
operator-framework:masterfrom
oceanc80:update-bindata
Mar 17, 2023
Merged

Update OLM version to 0.24.0#6362
oceanc80 merged 1 commit into
operator-framework:masterfrom
oceanc80:update-bindata

Conversation

@oceanc80

Copy link
Copy Markdown
Collaborator

Description of the change:
Updates OLM version in places missed by make bindata target.

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
@openshift-ci openshift-ci Bot requested review from anik120 and joelanford March 15, 2023 19:19
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive
@oceanc80 oceanc80 temporarily deployed to deploy March 15, 2023 19:20 — with GitHub Actions Inactive

@varshaprasad96 varshaprasad96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oceanc80 We need to update the docs and the e2e test to use the updated OLM version.

@oceanc80

oceanc80 commented Mar 15, 2023

Copy link
Copy Markdown
Collaborator Author

@varshaprasad96 The docs and e2e test were updated in these PRs: #6360 and #6359
I forgot that the make bindata command misses some files so I didn't manually fix them the first go round and needed this follow-up PR.

@varshaprasad96

Copy link
Copy Markdown
Member

@oceanc80 Ah, I see. Sorry missed it!

The e2e in master still uses to 0.23.1 though (

OlmVersionForTestSuite = "0.23.1"
).

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2023

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@varshaprasad96 varshaprasad96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@oceanc80 oceanc80 merged commit 411623e into operator-framework:master Mar 17, 2023
@oceanc80 oceanc80 deleted the update-bindata branch March 17, 2023 19:39
@oceanc80

Copy link
Copy Markdown
Collaborator Author

/cherry-pick v1.28.x

@openshift-cherrypick-robot

Copy link
Copy Markdown

@oceanc80: new pull request created: #6367

Details

In response to this:

/cherry-pick v1.28.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants