(testing): Bump K8S_VERSION for testing to 1.26.0#6351
Merged
everettraven merged 3 commits intoMar 14, 2023
Conversation
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Contributor
Author
|
/cc @rashmigottipati |
rashmigottipati
approved these changes
Mar 8, 2023
rashmigottipati
left a comment
Member
There was a problem hiding this comment.
Changes look good to me.
However, IMO, we should wait to merge this until SDK k8s bump PR gets merged first.
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Member
|
/hold remove |
varshaprasad96
approved these changes
Mar 14, 2023
varshaprasad96
left a comment
Member
There was a problem hiding this comment.
Just one nit, else
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
K8S_VERSIONin Makefile to 1.26.0 so that our testing environment uses k8s 1.26kindversion in Makefile to0.17.0so that it is up to date with the latest releasegolangci-lintversion in Makefile to1.51.2to fix a problem I had locally where runningmake lintresulted in my terminal or editor crashing.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs