registry_pod: Avoid grace period delay#5818
Conversation
f7342e3 to
bed75e3
Compare
The shell script does not propagate the SIGTERM signal that is sent to the pod when it is terminated; to avoid this, we run the last command to substitute the shell process, so that the pod stop immediately instead of waiting the 30 default seconds of the grace period when an user uninstall the operator by using 'operator-sdk cleanup ...' command. Signed-off-by: Alejandro Visiedo <avisiedo@redhat.com>
bed75e3 to
4748ba5
Compare
|
@avisiedo is there a github issue that explains the problem you were having? |
|
@jmrodri No, there is not. What am I missing to propose a change into the repository?
Please correct me on the above if I were wrong in something, and if an issue is required, let me know and I will create it, and I will update this PR to reference the issue. Thanks |
|
/retest |
|
@avisiedo: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jmrodri In the pipeline I get here and issue related with an external link. I have checked the link manually and it worked, probably network transitory situations; I can not relaunch the test to check it. 😅 If further changes are necessary, or an issue ticket is necessary for the change, please let me know and I will do it Cheers! 🙂 |
|
I have added an issue at: #5866 |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
1 similar comment
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of the change:
Substitute shell by the last command that serve the registry pod.
Motivation for the change:
The shell script does not propagate the SIGTERM signal that is sent to
the pod when it is terminated; to avoid this, we run the last command to
substitute the shell process, so that the pod stop immediately instead of
waiting the 30 default seconds of the grace period when an user uninstall
the operator by using 'operator-sdk cleanup ...' command.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsissue: #5866