Add option to use default auth with Crane image resolver#30
Merged
Conversation
3843c7a to
279ac31
Compare
Contributor
|
/rerun |
Contributor
|
/retest |
everettraven
approved these changes
Feb 10, 2023
everettraven
left a comment
Contributor
There was a problem hiding this comment.
One question but other than that looks good to me.
/lgtm
| if ok { | ||
| opts = append(opts, WithUserPassAuth(username, args["password"])) | ||
| } else { | ||
| usedefault := args["usedefault"] |
Contributor
There was a problem hiding this comment.
Does this default to false if the index doesn't exist?
Contributor
Author
There was a problem hiding this comment.
no, this defaults to empty string
Contributor
Author
|
hmm, trying to figure out why this error is happening, i'm able to reproduce it running the tests locally, although it seems like it might be because i'm on an m1 mac and the image isn't compatible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kinda weird that this forces no-auth as the default, but I've left that as the default option, and added the option to turn on Crane's default auth (which uses local auth, i.e. if you've already
docker login'd in your terminal, it will use that token or whatever).Fixes #6027 and #6095 in Operator SDK.