This repository was archived by the owner on Mar 3, 2025. It is now read-only.
🌱 e2e: add tests to verify metrics endpoint#483
Merged
tmshort merged 1 commit intoDec 13, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 38.23% 38.23%
=======================================
Files 15 15
Lines 1224 1224
=======================================
Hits 468 468
Misses 706 706
Partials 50 50 ☔ View full report in Codecov by Sentry. |
831bca0 to
ee64c83
Compare
ee64c83 to
bf04886
Compare
b242984 to
230202b
Compare
230202b to
f9676e6
Compare
f9676e6 to
b87765e
Compare
35a2362 to
cbaf448
Compare
tmshort
reviewed
Dec 13, 2024
tmshort
reviewed
Dec 13, 2024
tmshort
reviewed
Dec 13, 2024
2774f94 to
3ebe399
Compare
3ebe399 to
b30b516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the RFC https://docs.google.com/document/d/1hYOtHWcfoX_zWvy2YeolQBGuDgmP72vXMlrj9q9kPBQ/edit?tab=t.0 we would like to add the tests before get merge the PR: #460 just to ensure that the metrics work at the same way before and after the changes.
Motivation: operator-framework/operator-controller#1509