Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

🐛 Add check in test-e2e testing to ensure there's a cluster#474

Merged
LalatenduMohanty merged 1 commit into
operator-framework:mainfrom
tmshort:e2e-test-check
Dec 19, 2024
Merged

🐛 Add check in test-e2e testing to ensure there's a cluster#474
LalatenduMohanty merged 1 commit into
operator-framework:mainfrom
tmshort:e2e-test-check

Conversation

@tmshort

@tmshort tmshort commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort requested a review from a team as a code owner November 26, 2024 21:38
@codecov

codecov Bot commented Nov 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (adf64a0) to head (fa24b24).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #474   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort marked this pull request as draft November 26, 2024 21:44
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2024
camilamacedo86

This comment was marked as outdated.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@camilamacedo86

This comment was marked as outdated.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2024
@camilamacedo86

Copy link
Copy Markdown
Contributor

Hi @tmshort

I think in the way that is writing, the problem might be how we are getting the kubeconfig and client.
Just, an idea we might need to do something like:

If we want still doing in this way.

@camilamacedo86 camilamacedo86 dismissed their stale review November 27, 2024 02:40

based on the above comment.

@tmshort tmshort marked this pull request as ready for review December 2, 2024 15:03
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024

@LalatenduMohanty LalatenduMohanty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Dec 19, 2024
Merged via the queue into operator-framework:main with commit 7ae59a4 Dec 19, 2024
@tmshort tmshort deleted the e2e-test-check branch February 25, 2025 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants