This repository was archived by the owner on Mar 3, 2025. It is now read-only.
🐛 Remove check-cluster dependency from test-e2e#473
Merged
everettraven merged 1 commit intoNov 26, 2024
Conversation
`check-cluster` is already a dependency of the `install` targt, which is a dependency of `e2e`. It does not need to be a dependency of `test-e2e` which _just_ runs the tests without any setup. Signed-off-by: Todd Short <todd.short@me.com>
dtfranz
approved these changes
Nov 26, 2024
everettraven
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-clusteris already a dependency of theinstalltarget, which is a dependency ofe2e. It does not need to be a dependency oftest-e2ewhich just runs the tests without any setup.