Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

🌱 add verify-crd-compatibility make target and GHA#471

Merged
everettraven merged 2 commits into
operator-framework:mainfrom
everettraven:ci/crd-diff-check
Dec 2, 2024
Merged

🌱 add verify-crd-compatibility make target and GHA#471
everettraven merged 2 commits into
operator-framework:mainfrom
everettraven:ci/crd-diff-check

Conversation

@everettraven

Copy link
Copy Markdown
Collaborator

using the crd-diff tool with the same configuration as recently merged into operator-controller

using the crd-diff tool with the same configuration as recently
merged into operator-controller

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven requested a review from a team as a code owner November 26, 2024 14:19
@codecov

codecov Bot commented Nov 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (f7eee6e) to head (24d6e17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: everettraven <everettraven@gmail.com>

@tmshort tmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

But should wait until labeled 1.0.0

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@tmshort

tmshort commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@everettraven

Copy link
Copy Markdown
Collaborator Author

v1.0.0 has been released

/hold cancel

@everettraven everettraven added this pull request to the merge queue Dec 2, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
Merged via the queue into operator-framework:main with commit e711559 Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants