Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

✨ add a demo-update generation workflow step to let us know when we have broken demo generation#444

Merged
grokspawn merged 1 commit into
operator-framework:mainfrom
grokspawn:add-demo-gha
Oct 29, 2024
Merged

✨ add a demo-update generation workflow step to let us know when we have broken demo generation#444
grokspawn merged 1 commit into
operator-framework:mainfrom
grokspawn:add-demo-gha

Conversation

@grokspawn

Copy link
Copy Markdown
Contributor

No description provided.

@grokspawn grokspawn requested a review from a team as a code owner October 22, 2024 14:57
@codecov

codecov Bot commented Oct 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.83%. Comparing base (d8dc9e7) to head (dcff80e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files          15       15           
  Lines        1208     1208           
=======================================
  Hits          457      457           
  Misses        701      701           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn changed the title ✨ add a demo-update generation workflow step to let us know when we have broken demo generation WIP: ✨ add a demo-update generation workflow step to let us know when we have broken demo generation Oct 22, 2024
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@grokspawn grokspawn changed the title WIP: ✨ add a demo-update generation workflow step to let us know when we have broken demo generation ✨ add a demo-update generation workflow step to let us know when we have broken demo generation Oct 22, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@grokspawn

grokspawn commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

This should NOT be setting demo as a subset of unit (and therefore required). The intent of this PR is to create an NOT-REQUIRED CI step to inform contributors when they break the demo.

Found it

…e broken demo generation

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@LalatenduMohanty

Copy link
Copy Markdown
Member

@grokspawn What event will run this workflow?

@grokspawn

Copy link
Copy Markdown
Contributor Author

Right now it's just called 'demo'
image
you can see it running in the checks on this PR.

@m1kola m1kola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment on lines +3 to +9
on:
workflow_dispatch:
merge_group:
pull_request:
push:
branches:
- main

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LalatenduMohanty to your question - this section describes when the workflow will be triggered.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I read the question wrong. Yes, this is limited in scope to PRs pushing to main branch. (But folks can manually run the make target in their local to test.)

@grokspawn grokspawn added this pull request to the merge queue Oct 29, 2024
Merged via the queue into operator-framework:main with commit a049e01 Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants