Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

✨ update GoDoc comments to be accurate with latest api changes#423

Merged
grokspawn merged 5 commits into
operator-framework:mainfrom
everettraven:chore/api-sweep
Oct 3, 2024
Merged

✨ update GoDoc comments to be accurate with latest api changes#423
grokspawn merged 5 commits into
operator-framework:mainfrom
everettraven:chore/api-sweep

Conversation

@everettraven

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven requested a review from a team as a code owner October 3, 2024 18:24
Signed-off-by: everettraven <everettraven@gmail.com>
@codecov

codecov Bot commented Oct 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.28%. Comparing base (29d21c7) to head (c28507a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files          14       14           
  Lines         802      802           
=======================================
  Hits          283      283           
  Misses        472      472           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: everettraven <everettraven@gmail.com>
Comment thread api/core/v1alpha1/clustercatalog_types.go Outdated
everettraven and others added 2 commits October 3, 2024 14:51
Co-authored-by: Jordan Keister <jordan@nimblewidget.com>
Signed-off-by: everettraven <everettraven@gmail.com>
@grokspawn grokspawn enabled auto-merge October 3, 2024 18:56
@grokspawn grokspawn added this pull request to the merge queue Oct 3, 2024

@ankitathomas ankitathomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment

Comment thread api/core/v1alpha1/clustercatalog_types.go
Merged via the queue into operator-framework:main with commit 8137da0 Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants