Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

⚠️ Bump ClusterCatalog API to v1#380

Merged
everettraven merged 2 commits into
operator-framework:mainfrom
perdasilva:perdasilva/api/bump-to-v1
Nov 8, 2024
Merged

⚠️ Bump ClusterCatalog API to v1#380
everettraven merged 2 commits into
operator-framework:mainfrom
perdasilva:perdasilva/api/bump-to-v1

Conversation

@perdasilva

@perdasilva perdasilva commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bumps ClusterCatalog API to v1

Closes #341

@perdasilva perdasilva requested a review from a team as a code owner September 6, 2024 14:54
@codecov

codecov Bot commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 80.43478% with 9 lines in your changes missing coverage. Please review.

Project coverage is 38.23%. Comparing base (20acf03) to head (42e7239).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rnal/controllers/core/clustercatalog_controller.go 87.50% 4 Missing ⚠️
internal/source/containers_image.go 71.42% 1 Missing and 1 partial ⚠️
api/v1/zz_generated.deepcopy.go 0.00% 1 Missing ⚠️
cmd/manager/main.go 0.00% 1 Missing ⚠️
internal/webhook/cluster_catalog_webhook.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 5aadf86 to cd3937b Compare September 6, 2024 16:57
@perdasilva

perdasilva commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

/hold until we are ready to release

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2024
@perdasilva perdasilva marked this pull request as draft September 12, 2024 11:43
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from cd3937b to 33193d1 Compare September 25, 2024 15:23
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 33193d1 to 1e4f441 Compare October 16, 2024 08:20
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 16, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 1e4f441 to eaac7d8 Compare November 7, 2024 16:56
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch 2 times, most recently from 5a47124 to 541d79c Compare November 7, 2024 17:35
joelanford
joelanford reviewed Nov 7, 2024
View reviewed changes
Comment thread api/core/v1/clustercatalog_types.go
joelanford
joelanford reviewed Nov 7, 2024
View reviewed changes
Comment thread api/core/v1/clustercatalog_types_test.go Outdated
joelanford
joelanford reviewed Nov 7, 2024
View reviewed changes
Comment thread test/e2e/unpack_test.go Outdated
bump ClusterCatalog API to v1
04a98ea 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 541d79c to 04a98ea Compare November 7, 2024 17:56
@perdasilva perdasilva changed the title [HOLD] ⚠️ Bump ClusterCatalog API to v1 ⚠️ Bump ClusterCatalog API to v1 Nov 7, 2024
@perdasilva perdasilva marked this pull request as ready for review November 7, 2024 17:57
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@everettraven everettraven added this pull request to the merge queue Nov 8, 2024
@joelanford joelanford removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
Merged via the queue into operator-framework:main with commit 2f96c57 Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@joelanford joelanford joelanford left review comments

@everettraven everettraven everettraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

promote API from v1alpha1 to v1

4 participants

@perdasilva @joelanford @everettraven @openshift-merge-robot