fix(tests): Ensure mutable map deserialization#2791
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts REST Assured test configuration to avoid unintended Jackson module auto-discovery (introduced via shaded Scala module), restoring Java LinkedHashMap deserialization behavior for JSON objects.
Changes:
- Configure REST Assured with a plain
ObjectMapper(nofindAndRegisterModules()). - Add REST Assured
ObjectMapperConfigsetup inAbstractRestServiceTest.
feel-engine 1.21.0 (scala-shaded) now ships META-INF/services/ com.fasterxml.jackson.databind.Module registering DefaultScalaModule. REST Assured's DefaultJackson2ObjectMapperFactory calls ObjectMapper.findAndRegisterModules(), which auto-discovers this module and causes Jackson to deserialize JSON objects as Scala immutable maps instead of java.util.LinkedHashMap. Fix by configuring REST Assured in AbstractRestServiceTest to use a plain ObjectMapper() without auto-registering modules, restoring the pre-1.21.0 deserialization behavior. Fixes failures in: - DeploymentRestServiceInteractionTest#testGetDeploymentResources - ProcessInstanceRestServiceInteractionTest#testGetProcessInstanceComments - TaskRestServiceInteractionTest#testGetTaskAttachments - TaskRestServiceInteractionTest#testGetTaskComments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
7e103b4 to
44f9a97
Compare
|
Contributor
Author
|
related to #2794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feel-engine 1.21.0 (scala-shaded) now ships META-INF/services/ com.fasterxml.jackson.databind.Module registering DefaultScalaModule. REST Assured's DefaultJackson2ObjectMapperFactory calls ObjectMapper.findAndRegisterModules(), which auto-discovers this module and causes Jackson to deserialize JSON objects as Scala immutable maps instead of java.util.LinkedHashMap.
Fix by configuring REST Assured in AbstractRestServiceTest to use a plain ObjectMapper() without auto-registering modules, restoring the pre-1.21.0 deserialization behavior.
Fixes failures in: